Skip to content

Conversation

@notoriaga
Copy link
Contributor

really-old
old
new

@@ -0,0 +1,46 @@
// This is the source to QtQuick2's Material CheckBox with some changes to make it smaller
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a little jank but I guess this is the recommended way to customize a qtquick control - https://doc.qt.io/qt-5/qtquickcontrols2-customize.html#customizing-a-control

We could do it in place but it requires changing a few fields (to size the checkbox as well as the animation). Would also like to slightly shrink the inner check mark but can't seem to figure out how

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to figure out making the checks smaller
checks

@notoriaga
Copy link
Contributor Author

notoriaga commented Oct 27, 2021

Also worth mentioning, it appears that the qtquick material style has a 'dense' variant - https://doc.qt.io/qt-5/qtquickcontrols2-material.html#variants

Sounds like it's recommend for desktop apps. I tried to enable it but couldn't see any difference. Might be worth taking a look into, a lot of the controls feel a little large

@notoriaga notoriaga requested a review from a team October 27, 2021 19:21
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@notoriaga notoriaga merged commit 323db02 into main Oct 27, 2021
@notoriaga notoriaga deleted the steve/tracking-tab branch October 27, 2021 23:02
@silverjam
Copy link
Contributor

Also worth mentioning, it appears that the qtquick material style has a 'dense' variant - https://doc.qt.io/qt-5/qtquickcontrols2-material.html#variants

Sounds like it's recommend for desktop apps. I tried to enable it but couldn't see any difference. Might be worth taking a look into, a lot of the controls feel a little large

I was able to get the "Dense" variant to work, very slight adjustment:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants