Skip to content

set correct value for pos fix mode in solution tab [CPP-377] #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

set correct value for pos fix mode in solution tab [CPP-377] #194

merged 1 commit into from
Oct 28, 2021

Conversation

@notoriaga
Copy link
Contributor

No description provided.

@notoriaga notoriaga requested a review from a team October 28, 2021 18:53
silverjam
silverjam approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, too bad we can't use a structured type here

@notoriaga
Copy link
Contributor Author

I think we could because we know all the fields ahead of time. I'm guessing this was done so looping over all the fields was easy (needed for capnproto stuff). I'm sure there is a macro out there that adds an iter_fields or something to a struct, we could probably do that

@notoriaga notoriaga merged commit c30afc2 into main Oct 28, 2021
@notoriaga notoriaga deleted the steve/cpp-377 branch October 28, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notoriaga @silverjam