-
Notifications
You must be signed in to change notification settings - Fork 2
About Me and the removal of side drawer.[CPP-166][CPP-274] #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly property int bottomPadding: 20 | ||
readonly property string supportWebsite: "https://swiftnav.com/support" | ||
readonly property string website: "https://www.swiftnav.com" | ||
readonly property string copyrightText: "Copyright © 2011-2022 Swift Navigation Inc." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preparing for the future I see 😎
Co-authored-by: Jason Mobarak <[email protected]>
Co-authored-by: Jason Mobarak <[email protected]>
Co-authored-by: Jason Mobarak <[email protected]>
pragma Singleton | ||
|
||
QtObject { | ||
property string consoleVersion: "0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on how we can update this in the future? Can we pull in the version from a file or console resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have it tied to when it is provided in the Update tab. So would show as 0.0.0 until the first connection. Maybe I should disable this button before the first connection as well? Currently our version.txt file is not created in the resources folder so that would need to be changed for us to get it available before first connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would pretty odd to require a customer to connect to a device just to see about information. The version information definitely needs to be accessible without that. Why is knowing the current version of the app dependent on connecting to a device? That seems super awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few asks:
- Expose current app version information without requiring a connection
- Add a hover text explaining what clicking on the SwiftNav logo will do, e.g. "About this application"
Done. I agree requiring a connection doesn't make sense and the about me should be available before first connection. I threw it into the connection proto so it is now available on app start. Also added the hover over. I have also added selectable text to the licenses. Although this still is gated by the copy bug we have but when it gets resolved should work 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The licenses have embedded links in the text which we can either manually edit them to embed hrefs or do some form of regex which seems too hacky? Maybe the entire license should just be a link to where it would be found?
Kazam_screencast_00004.mp4