Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

  • Replace side drawer with dialog popup which contains (About Me and Licenses).
  • Replaces hamburgler button with Swift logo.

The licenses have embedded links in the text which we can either manually edit them to embed hrefs or do some form of regex which seems too hacky? Maybe the entire license should just be a link to where it would be found?

Kazam_screencast_00004.mp4

@john-michaelburke john-michaelburke requested a review from a team October 29, 2021 02:57
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background for the new button is white, can it be transparent like the other buttons?

image

readonly property int bottomPadding: 20
readonly property string supportWebsite: "https://swiftnav.com/support"
readonly property string website: "https://www.swiftnav.com"
readonly property string copyrightText: "Copyright © 2011-2022 Swift Navigation Inc."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparing for the future I see 😎

@john-michaelburke
Copy link
Collaborator Author

Background for the new button is white, can it be transparent like the other buttons?

Done. So looks like the tab bar had some default background color "nonwhite" and actually all other tab bars we have been using, are using this color. So I hardcoded this sideNavBar to use this color.
Screen Shot 2021-10-28 at 9 59 28 PM

pragma Singleton

QtObject {
property string consoleVersion: "0.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on how we can update this in the future? Can we pull in the version from a file or console resource?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it tied to when it is provided in the Update tab. So would show as 0.0.0 until the first connection. Maybe I should disable this button before the first connection as well? Currently our version.txt file is not created in the resources folder so that would need to be changed for us to get it available before first connection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would pretty odd to require a customer to connect to a device just to see about information. The version information definitely needs to be accessible without that. Why is knowing the current version of the app dependent on connecting to a device? That seems super awkward.

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few asks:

  • Expose current app version information without requiring a connection
  • Add a hover text explaining what clicking on the SwiftNav logo will do, e.g. "About this application"

@john-michaelburke
Copy link
Collaborator Author

john-michaelburke commented Oct 29, 2021

  • Expose current app version information without requiring a connection
  • Add a hover text explaining what clicking on the SwiftNav logo will do, e.g. "About this application"

Done. I agree requiring a connection doesn't make sense and the about me should be available before first connection. I threw it into the connection proto so it is now available on app start. Also added the hover over.

I have also added selectable text to the licenses. Although this still is gated by the copy bug we have but when it gets resolved should work 😄

@john-michaelburke john-michaelburke changed the title About Me and the removal of side drawer.[CPP-166] About Me and the removal of side drawer.[CPP-166][CPP-274] Oct 29, 2021
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@john-michaelburke john-michaelburke merged commit 72e93a8 into main Oct 29, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/about-me branch October 29, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants