Tracking tab view improvements #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I had erroneously used anchors for the TrackingSignalsTab and TrackingSkyPlotTab. Since these are in a layout, they shouldn't use anchors (and the QML engine complains about that). Instead use Layout.fillWidth Layout.fillHeight. * Remove unused code, commented out code.
* This improves the size and placement of the chart and legend in the TrackingSignalsTab, and improves fonts, making sure to use Roboto font, and making titles not bold.
* Fix the logic that deals with unchecking of series in the TrackingSignalsTab. Prior to this, unchecking series led to inconsistent results, with series still showing past history.
* Remove the "Show Legend" checkbox in TrackingSignalsTab. This no longer is necessary since the legend can be hidden away by clicking on it's title area. * Add a "Toggle All" checkbox in it's place - which will toggle all checkboxes on if some of them are off, and toggle all of them off if they are all on.
silverjam
changed the title
silverjam
approved these changes
Oct 29, 2021
* This fixes issues with determining the height when the number of cells total in the legend goes underneath the maxCellsPerColumn. Now it properly shows all cells when #cells goes under maxCellsPerColumn. * Fixed a small issue in width to prevent tiny amount of scrolling if no scrolling should be needed due to all cells shown.
Requests from J-M and Jason * Reduce font size of the axis labels and title * Make the chart title bold again.
* This adds the ability to use a standard vertical scroll wheel to scroll the legend in the Tracking Signals tab.
* Per J-M's request, scrolling down will scroll the legend to the right
* This moves the legend created for the TrackingSignalTab to a separate file for use elsewhere. * Properties that were specific to the TrackingSignalTab were defaulted or parameterized, customized where they are used in the TrackingSignalTab
I forgot to parameterize the model in the legend. This does that, and sets it where it's used in TrackingSignalsTab.
john-michaelburke
deleted the
keithel-qt/trackingtab-view-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196
Add "Toggle All", remove "Show Legend" in TrackingSignalsTab
This no longer is necessary since the legend can be hidden away by
clicking on it's title area.
checkboxes on if some of them are off, and toggle all of them off if
they are all on.
Fix unchecking of series in the TrackingSignalsTab
TrackingSignalsTab. Prior to this, unchecking series led to
inconsistent results, with series still showing past history.
Reduce margin, improve size/placement of chart
TrackingSignalsTab, and improves fonts, making sure to use Roboto
font, and making titles not bold.
Fix sizing in TrackingTab, remove unused code
I had erroneously used anchors for the TrackingSignalsTab and
TrackingSkyPlotTab. Since these are in a layout, they shouldn't use
anchors (and the QML engine complains about that). Instead use
Layout.fillWidth Layout.fillHeight.
Remove unused code, commented out code.