Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

No description provided.

@john-michaelburke john-michaelburke requested a review from a team November 3, 2021 19:40
# sys.argv.append("-qmljsdebugger=port:10002,block")
debug = QQmlDebuggingEnabler() # pylint: disable=unused-variable
if not is_frozen():
# sys.argv.append("-qmljsdebugger=port:10002,block")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the commented out bit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT that is what will enable the qml debugger that can be viewed in-browser. That being said I don't think it ever worked for us. @keithel-qt What do we gain with this QQmlDebuggingEnabler? Should we just remove this entirely?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move it to the README.md file I guess.
I wouldn't delete it entirely, as there isn't good official Qt documentation on how to enable this in Python Qt projects.

Someone else should try this out to see if it works for them. It definitely works for simpler (non-rust) PySide2 applications. I've tried it out and it works fairly well.

Some investigating to figure out the source of why it's not working with console_pp probably should be done, doing a reduction approach to figuring out what in console_pp is causing it.. Remove chunks of the app until it starts to work again, then adding stuff back in until it breaks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I moved it to the Readme and created a ticket.

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/disable-emoji branch from e0d3d40 to c286972 Compare November 4, 2021 18:11
@john-michaelburke john-michaelburke merged commit b6382a0 into main Nov 5, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/disable-emoji branch November 5, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants