Tracking skyplot optimization (#203) #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This defines a common rounded rectangle radius for chart legends in QML Constants, and makes SkyPlot chart legend use it for improved look.
* This improves the styling of the control checkboxes at the bottom of the Sky Plot tab, using the newer small checkboxes, and centering them. * This also does a little bit of improvement to when the labels and lagend are shown, by restarting the timer.
* Bound tab visibility to series length * Set the constant things in the series from QML instead of python. (width and use OpenGL) * Have timer triggered on start so there's less time before data is populated.
* Populate the SkyPlot series data from Python, reducing round trip calls from QML into Python, back into QML again. * Make point labels show and hide synchronized with the enabling and disabling of the labels, as well as when series are hidden and shown. * Now just about all elements in the tab that reference series data are referencing that data directly from the series via all_series series list.
| series.axisYRight = trackingSignalsYAxis; | ||
| series.width = Constants.commonChart.lineWidth; | ||
| // Color and useOpenGL will be set in Python with fill_all_series call. | ||
| series.useOpenGL = Globals.useOpenGL; |
There was a problem hiding this comment.
Yeah, I decided it was silly I was pushing this down into Python to set.
| id: trackingSignalsCheckboxes | ||
|
|
||
| Layout.fillWidth: true | ||
| Layout.preferredHeight: Constants.trackingSkyPlot.checkboxHeight |
There was a problem hiding this comment.
I think this hardcoded space is too large now with the reduction of the size of the checkboxes. Either need to set to the anticipated size of the checkmarks or remove this line so it just uses the minimum necessary height.
There was a problem hiding this comment.
Fixed! Looks even better. Good catch.
|
That CI test that failed is flaky "realtime delay" so feel free to just rerun if you see this |
* Remove extra explicit height specified in the TrackingSkyPlotTab checkbox row. * Remove unused trackingSkyPlot constants from Constants.qml
|
john-michaelburke
approved these changes
Nov 10, 2021
john-michaelburke
deleted the
keithel-qt/tracking-skyplot-optimization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes drawing of the skyplot chart, and the tab in general.
Populate SkyPlot series data from Python
calls from QML into Python, back into QML again.
disabling of the labels, as well as when series are hidden and shown.
referencing that data directly from the series via all_series series
list.
Small improvements to the Tracking Signals tab
(width and use OpenGL)
populated.
Use small checkboxes, improve check layout in skyplot
the Sky Plot tab, using the newer small checkboxes, and centering
them.
lagend are shown, by restarting the timer.
Define common rounded rect radius for legends
QML Constants, and makes SkyPlot chart legend use it for improved
look.