[CPP-58] Add pylint support for PySide2 imports #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes inline comments to avoid PySide2 imports being ignored. Also re-enables some pylint rules that do not need to be disabled.
In Rust 2021, panic messages must be a string literal.
silverjam
approved these changes
Mar 29, 2021
john-michaelburke
approved these changes
Mar 29, 2021
silverjam
reviewed
Mar 29, 2021
| from PySide2.QtWidgets import QApplication # type: ignore # pylint: disable=no-name-in-module | ||
| from PySide2.QtWidgets import QApplication # type: ignore | ||
|
|
||
| from fbs_runtime.application_context.PySide2 import ApplicationContext # type: ignore # pylint: disable=unused-import |
There was a problem hiding this comment.
@john-michaelburke we don't use this anymore so we should be able to remove this import
There was a problem hiding this comment.
@silverjam We still need the fbs_runtime import as it is needed when building the installer. Here is the error provided when commented out.
jm@ubuntu:~/dev/console_pp$ ./target/swift_navigation_console/swift_navigation_console
Traceback (most recent call last):
File "fbs_pyinstaller_hook.py", line 2, in <module>
File "importlib/__init__.py", line 127, in import_module
File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
File "<frozen importlib._bootstrap>", line 991, in _find_and_load
File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
File "<frozen importlib._bootstrap>", line 991, in _find_and_load
File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'fbs_runtime'
[71539] Failed to execute script fbs_pyinstaller_hook
jm@ubuntu:~/dev/console_pp$
There was a problem hiding this comment.
just add a comment about why it's there then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.