Changes to ease the move to PySide6 #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Label is Swift Material styled, Text is not. * Label will pick up the Roboto font in the right size, and will also follow other customizations in the style. Amended for PySide2 - Add QtQuick.Controls 2.15 import,
* This works around a bug in Qt that I reported this morning: https://bugreports.qt.io/browse/QTBUG-98241 * The bug only shows itself in very specific machine configurations it seems - Windows 10, with more than one monitor, secondary monitor at a fractional scale factor (or maybe just a different scale factor from the primary)
* In Qt6, sequence is no longer present in Shortcuts, so this migrates to setting the sequences property instead, which works just as well.
* This changes all static paths to files used in the application to be done as resources using qrc:// * With the switch to PySide6, there were some cases where it could not find where the files were because of differences of when to treat a path as a resource path or not, I believe.
john-michaelburke
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qrc://prefixsequencesproperty instead ofsequenceproperty in Shortcuts, as the latter is removed in PySide6 due tosequencebeing redundant.Textelement was used with styleableLabelelement. A prior commit replaced all instances ofTextwithLabel, however new changes that use this were added since.