Skip to content

Conversation

@notoriaga
Copy link
Contributor

@notoriaga notoriaga commented Nov 19, 2021

As the title suggests this makes the settings client run in a different thread than the main process_messages loop. This should fix the issue of the whole app freezing if the settings request bugs out. Obviously this doesn't fix whatever the underlying issue we are running into is, but this might be a good idea just in case.

Also switches to the native rust settings library here - swift-nav/libsettings-rs#15

@notoriaga
Copy link
Contributor Author

Have not seen it hang for a while using this - swift-nav/libsettings-rs#15

@notoriaga notoriaga changed the title process settings tab messages in a separate thread process settings tab messages in a separate thread [CPP-405] Nov 23, 2021
@notoriaga notoriaga requested a review from a team December 1, 2021 18:55
Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@notoriaga notoriaga merged commit 189dc93 into main Dec 1, 2021
@notoriaga notoriaga deleted the steve/settings-thd branch December 1, 2021 20:07
@silverjam
Copy link
Contributor

@notoriaga @john-michaelburke Assuming we need to, can we update the threading diagram here: https://github.com/swift-nav/swift-toolbox/blob/main/docs/DESIGN.md#backend-threads-diagram? Also noticed that we don't have the source for that diagram in GitHub, draw.io supports storing/pulling files from GitHub, so we should give that a try.

@notoriaga
Copy link
Contributor Author

@notoriaga @john-michaelburke Assuming we need to, can we update the threading diagram here: https://github.com/swift-nav/swift-toolbox/blob/main/docs/DESIGN.md#backend-threads-diagram? Also noticed that we don't have the source for that diagram in GitHub, draw.io supports storing/pulling files from GitHub, so we should give that a try.

Nice I'll check it out/update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants