-
Notifications
You must be signed in to change notification settings - Fork 2
process settings tab messages in a separate thread [CPP-405] #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
67c45d0 to
c0af714
Compare
33da534 to
700920e
Compare
|
Have not seen it hang for a while using this - swift-nav/libsettings-rs#15 |
16b0997 to
300ac2e
Compare
300ac2e to
fc394e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
@notoriaga @john-michaelburke Assuming we need to, can we update the threading diagram here: https://github.com/swift-nav/swift-toolbox/blob/main/docs/DESIGN.md#backend-threads-diagram? Also noticed that we don't have the source for that diagram in GitHub, draw.io supports storing/pulling files from GitHub, so we should give that a try. |
Nice I'll check it out/update it |
As the title suggests this makes the settings client run in a different thread than the main
process_messagesloop. This should fix the issue of the whole app freezing if the settings request bugs out. Obviously this doesn't fix whatever the underlying issue we are running into is, but this might be a good idea just in case.Also switches to the native rust settings library here - swift-nav/libsettings-rs#15