Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Apr 1, 2021

  • setting "antialiasing" on the chart gets rid of the jagged / tearing artifacts I was seeing on my machine

  • setting the useOpenGL property reduces CPU usage from 2-3% to 0.5-1% on my machine

Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM not 100% sure but there may be some issues with the installers with the "useOpenGL" flag set to true if we are removing the necessary dlls to use it.

@silverjam
Copy link
Contributor Author

LGTM not 100% sure but there may be some issues with the installers with the "useOpenGL" flag set to true if we are removing the necessary dlls to use it.

ok, I'll sit on this for a bit and see if the installers work

@john-michaelburke
Copy link
Collaborator

@silverjam What I suspected was correct. Seems like the mac and linux installers are bricked doing this:

data/piksi-relay-1min.sbp
Opened file successfully!
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.

@silverjam
Copy link
Contributor Author

@silverjam What I suspected was correct. Seems like the mac and linux installers are bricked doing this:

data/piksi-relay-1min.sbp
Opened file successfully!
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.
QOpenGLFramebufferObject: Framebuffer incomplete attachment.
QOpenGLFramebufferObject: Framebuffer incomplete, missing attachment.

I get that too, but everything still launches correctly.

@silverjam
Copy link
Contributor Author

I tried the Windows installer on the benchmark machine, it seemed to work fine, but running the macOS installer failed with an unrelated error:

Last login: Wed Mar 17 09:45:40 on ttys001
(base) consolebench@Consoles-Mac-mini macOS % /Users/consolebench/Desktop/main.app/Contents/MacOS/main 
qt.qpa.fonts: Populating font family aliases took 163 ms. Replace uses of missing font family "Roboto" with one that exists to avoid this cost. 
kj/filesystem-disk-unix.c++:1690: warning: PWD environment variable doesn't match current directory; pwd = /Users/consolebench/actions-runner/_work/console_pp/console_pp/output/macOS
Traceback (most recent call last):
  File "/Users/consolebench/Desktop/main.app/Contents/MacOS/main.py", line 356, in <module>
  File "capnp/lib/capnp.pyx", line 4034, in capnp.lib.capnp.load
  File "capnp/lib/capnp.pyx", line 3297, in capnp.lib.capnp.SchemaParser.load
capnp.lib.capnp.KjException: kj/filesystem-disk-unix.c++:1704: failed: getcwd(): No such file or directory
stack: 104d56541 104c73a07 104ca8101 10484fa9d 104c47fe0 104cfeed9 10407634d 10401431b 1040aac4e 104067c98 7fff6ba93cc8 0
(base) consolebench@Consoles-Mac-mini macOS %

@john-michaelburke
Copy link
Collaborator

I will create a ticket for the mac installer issue https://swift-nav.atlassian.net/browse/CPP-92

I tried the Windows installer on the benchmark machine, it seemed to work fine, but running the macOS installer failed with an unrelated error:

Last login: Wed Mar 17 09:45:40 on ttys001
(base) consolebench@Consoles-Mac-mini macOS % /Users/consolebench/Desktop/main.app/Contents/MacOS/main 
qt.qpa.fonts: Populating font family aliases took 163 ms. Replace uses of missing font family "Roboto" with one that exists to avoid this cost. 
kj/filesystem-disk-unix.c++:1690: warning: PWD environment variable doesn't match current directory; pwd = /Users/consolebench/actions-runner/_work/console_pp/console_pp/output/macOS
Traceback (most recent call last):
  File "/Users/consolebench/Desktop/main.app/Contents/MacOS/main.py", line 356, in <module>
  File "capnp/lib/capnp.pyx", line 4034, in capnp.lib.capnp.load
  File "capnp/lib/capnp.pyx", line 3297, in capnp.lib.capnp.SchemaParser.load
capnp.lib.capnp.KjException: kj/filesystem-disk-unix.c++:1704: failed: getcwd(): No such file or directory
stack: 104d56541 104c73a07 104ca8101 10484fa9d 104c47fe0 104cfeed9 10407634d 10401431b 1040aac4e 104067c98 7fff6ba93cc8 0
(base) consolebench@Consoles-Mac-mini macOS %

@silverjam silverjam merged commit 4db5fed into main Apr 1, 2021
@silverjam silverjam deleted the silverjam/use-antialiasing branch April 1, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants