Create SwiftTableView reusable component #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the SwiftTableView reusable component and use it in one location in the app as a sample - the ThreadStateTable.
|
Oops forgot to run check |
john-michaelburke
approved these changes
Dec 2, 2021
I'll convert the others
|
👍 |
|
One small change with this is that all places you put this will have the onWidthChanged: tableView.forceLayout() call, but I think that's ok. If you don't want to incur that on tables that relayout using your column resize logic, you could pull that out and do the forceLayout in each use of SwiftTableView. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the SwiftTableView reusable component and use it in one location
in the app as a sample - the ThreadStateTable.