Skip to content

Conversation

@john-michaelburke
Copy link
Collaborator

Two concerns:

  • We found that the batch_size parameter in Fileio is not being used which could be related to the slower upgrade processing seen when compared to old console. I created a ticket here: https://swift-nav.atlassian.net/browse/CPP-472
  • The status bar handler is not used/joined anywhere. I am going to be moving this out of the tabs so it can run detached in a future PR, instead of handling the join, I will just tag as deadcode.

@john-michaelburke john-michaelburke requested a review from a team December 3, 2021 00:53
@john-michaelburke john-michaelburke merged commit 5d84fa9 into main Dec 3, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/status-bar-detached branch December 3, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants