Connect sbp recording size and add clear button to log panel[CPP-401] #272
Conversation
john-michaelburke
commented
Dec 10, 2021
john-michaelburke
commented
- Allow frontend to calculate recording size via raw bytes.
- Add clear button to log panel.
- Have log panel clear and pause button inherit SwiftButton.
- Moved refresh recording function to utils where other similar "refresh and send to frontend" functions are located for consistency.
|
|
||
| let mut logging_bar_status = msg.init_logging_bar_recording_status(); | ||
| logging_bar_status.set_recording_duration_sec(duration); | ||
| logging_bar_status.set_recording_size(size); |
There was a problem hiding this comment.
The only change here is sending the size parameter instead of passing it to bytes_to_human_readable before sending to frontend. Now frontend will do the calculation and produce the string.
john-michaelburke
force-pushed
the
john-michaelburke/logging-bar-adj-clear-button
branch
from
53ca4c2 to
62853de
Compare
|
Are there changes to diagrams in this PR? |
This is due to our newline formatter. It is just adding a newline. Could either add it to the exclusions or just add the new line 😄 |
I would add it to the exclusions, the next time we update it with draw.io it'll probably drop the newline again |
john-michaelburke
force-pushed
the
john-michaelburke/logging-bar-adj-clear-button
branch
from
62853de to
5b6c128
Compare
|
Looks like we did not have exclusions for the newline formatter. I added some simple regex matcher with some reasonable patterns. |
john-michaelburke
force-pushed
the
john-michaelburke/logging-bar-adj-clear-button
branch
from
5b6c128 to
1f82196
Compare
john-michaelburke
deleted the
john-michaelburke/logging-bar-adj-clear-button
branch
2 participants
