Skip to content

Changed the IMU tab color scheme to match original console[CPP-389]. #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

Changed the IMU tab color scheme to match original console[CPP-389]. #282

merged 1 commit into from
Dec 15, 2021

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Dec 14, 2021 •
edited
Loading

Screen Shot 2021-12-14 at 12 36 09 PM

@john-michaelburke john-michaelburke requested review from a team and dgburr and removed request for a team December 14, 2021 21:37
dgburr
dgburr approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@dgburr dgburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at least makes it consistent with the old version, although I think in the longer term we should find 6 colours which are easy to see with both light and dark themes

@john-michaelburke
Copy link
Collaborator Author

This at least makes it consistent with the old version, although I think in the longer term we should find 6 colours which are easy to see with both light and dark themes

I've been referencing https://colorbrewer2.org/#type=qualitative&scheme=Set1&n=7 if there is another collection you prefer

@john-michaelburke john-michaelburke merged commit d124d1b into main Dec 15, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/CPP-389 branch December 15, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgburr dgburr dgburr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @dgburr