add units to baseline table items [CPP-452] #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah it should be degrees I just did not know how to make the symbol in my notes as I was jotting them down haha. I added this comment to the other ticket for Solution tab: Vert/Horiz Acc should be in meters we converted from mm. |
Ahh perfect, thanks |
john-michaelburke
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ones mentioned in the ticket, also I assume we wanted united for
EandDin addition toN. Also for heading the ticket said[^]. I assume it's in degrees, should we be using[°]instead? is^a convention? Similarly, shouldVert Acc/Horiz Accbe[m/s]?