Skip to content

fix solution table field precision [CPP-443] #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix solution table field precision [CPP-443] #286

merged 2 commits into from
Dec 15, 2021

Conversation

notoriaga
Copy link
Contributor

No description provided.

@notoriaga notoriaga requested a review from a team December 15, 2021 18:29
@notoriaga
Copy link
Contributor Author

@john-michaelburke status_bar_thread_test seems a little flaky, there are some sleeps there maybe they need to be tweaked a bit?

john-michaelburke
john-michaelburke reviewed Dec 15, 2021
View reviewed changes
console_backend/src/solution_tab.rs
if let Some(age_corrections_) = self.age_corrections {
self.table
.insert(CORR_AGE_S, format!("{}", age_corrections_));
.insert(CORR_AGE_S, format!("{:.1}", age_corrections_));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to zero pad this as well if it is a fraction of a second.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work, is this what you mean? https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=58ad805bb52c89561f3c8b28f22db780

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting I guess that makes sense not sure what I was thinking.

@john-michaelburke
Copy link
Collaborator

john-michaelburke commented Dec 15, 2021 •
edited
Loading

@john-michaelburke status_bar_thread_test seems a little flaky, there are some sleeps there maybe they need to be tweaked a bit?

I'll create a PR with a tweak.

@notoriaga notoriaga merged commit cd1e1f0 into main Dec 15, 2021
@notoriaga notoriaga deleted the steve/cpp-443 branch December 15, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@john-michaelburke john-michaelburke john-michaelburke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notoriaga @john-michaelburke