remove angle from solution vel axis label [CPP-446] #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I'm not sure what the rational was in the choice of positioning of axis titles. |
john-michaelburke
requested changes
Dec 15, 2021
|
|
||
| Layout.alignment: Qt.AlignBottom | ||
| Layout.bottomMargin: Constants.commonChart.margin | ||
| Layout.bottomMargin: Constants.solutionVelocity.chartBottomMargin |
There was a problem hiding this comment.
Probably need to remove this line.
john-michaelburke
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I noticed was that the solution position chart has the y-axis labels on the right and the legend on the left. And the solution chart has labels on the left and the legend on the right. The old console is like that as well, but IMHO we might want to consider keeping that kind of thing consistent across all the tables