-
Notifications
You must be signed in to change notification settings - Fork 2
[CPP-39][CPP-40] Solution Tab - Table and Position Plot #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aelburke/solution-table
1c8986e
to
21eab17
Compare
jayvdb
reviewed
Apr 12, 2021
21eab17
to
67f78b4
Compare
jayvdb
reviewed
Apr 12, 2021
67f78b4
to
6ae39fc
Compare
jayvdb
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
aa734db
to
400e293
Compare
400e293
to
2e51994
Compare
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
reviewed
Apr 13, 2021
notoriaga
approved these changes
Apr 14, 2021
silverjam
reviewed
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, too slow on my review, this is what I had so far
silverjam
reviewed
Apr 14, 2021
I'll throw these into a new PR if you want to add more feel free! |
Merged
silverjam
reviewed
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Solution tab's table and position plot. Some less important features have been pushed off to get this first pass merged in.
Some work has been pulled over from ICBINS to perform some csv logging (which is one of the features pushed off for now):
I added some fairly basic unittests but there is definitely room for improvement so I created a ticket for this as well.
Here are tickets for the missing features:
CPP-96 - Implement Chart zoom via mouse scroll feature for Position Tab
CPP-97 - Implement Scollbar for Table.
CPP-98 - Implement Latitude Ticks show inside chart Position Tab.
CPP-99 - Implement ability to change units for Position Tab.
CPP-100 - Implement custom marker(s) for Position chart (only available circle/rectangle) need +
CPP-101 - Implement Center on Solution feature for Position Chart.
CPP-106 - Validate the logging implemented for velocity and position in Solution Tab.
CPP-107 - Add more unittests to solution tab and include more breadth to handle_pos_llh_test