Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Apr 9, 2021

This PR implements the Solution tab's table and position plot. Some less important features have been pushed off to get this first pass merged in.

Some work has been pulled over from ICBINS to perform some csv logging (which is one of the features pushed off for now):

  • formatters.rs
  • output.rs

I added some fairly basic unittests but there is definitely room for improvement so I created a ticket for this as well.

Here are tickets for the missing features:
CPP-96 - Implement Chart zoom via mouse scroll feature for Position Tab
CPP-97 - Implement Scollbar for Table.
CPP-98 - Implement Latitude Ticks show inside chart Position Tab.
CPP-99 - Implement ability to change units for Position Tab.
CPP-100 - Implement custom marker(s) for Position chart (only available circle/rectangle) need +
CPP-101 - Implement Center on Solution feature for Position Chart.
CPP-106 - Validate the logging implemented for velocity and position in Solution Tab.
CPP-107 - Add more unittests to solution tab and include more breadth to handle_pos_llh_test

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/solution-table branch from 1c8986e to 21eab17 Compare April 12, 2021 21:31
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/solution-table branch from 21eab17 to 67f78b4 Compare April 12, 2021 23:09
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/solution-table branch from 67f78b4 to 6ae39fc Compare April 13, 2021 03:18
@john-michaelburke john-michaelburke marked this pull request as ready for review April 13, 2021 03:27
@john-michaelburke john-michaelburke requested review from a team and silverjam April 13, 2021 03:27
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/solution-table branch from aa734db to 400e293 Compare April 13, 2021 19:08
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/solution-table branch from 400e293 to 2e51994 Compare April 13, 2021 19:28
@john-michaelburke john-michaelburke merged commit 2830e8c into main Apr 14, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/solution-table branch April 14, 2021 17:13
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, too slow on my review, this is what I had so far

@john-michaelburke
Copy link
Collaborator Author

I'll throw these into a new PR if you want to add more feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants