add more units to solution table [CPP-447] #295
Conversation
console_backend/src/constants.rs
Outdated
| pub(crate) const VERT_ACC: &str = "Vert Acc [m]"; | ||
| pub(crate) const POS_FLAGS: &str = "Pos Flags"; | ||
| pub(crate) const INS_USED: &str = "INS Used"; | ||
| pub(crate) const INS_USED: &str = "INS Used [true/false]"; |
There was a problem hiding this comment.
Went with lowercase here because that's how the values show up in the table
There was a problem hiding this comment.
Ah this was not actually a request to make the units display, I apologize. This was a request to make the lowercase true/false show up capitalized in the table. 😬 my bad
There was a problem hiding this comment.
Ahh I see, makes sense. I imagine that's how it appears everywhere because thats how rust formats bools, I can change them all
| pub(crate) const ROLL_ACC: &str = "Roll Acc [°]"; | ||
| pub(crate) const PITCH_ACC: &str = "Pitch Acc [°]"; | ||
| pub(crate) const YAW_ACC: &str = "Yaw Acc [°]"; | ||
| pub(crate) const COV_N_N: &str = "LLH Cov N-N [m^2]"; |
There was a problem hiding this comment.
LLH Cov units from here -
| pub(crate) const VEL_E: &str = "Vel. E [m/s]"; | ||
| pub(crate) const VEL_D: &str = "Vel. D [m/s]"; | ||
| pub(crate) const VEL_FLAGS: &str = "Vel. Flags"; | ||
| pub(crate) const PDOP: &str = "PDOP"; |
There was a problem hiding this comment.
As far as I can tell PDOP etc. seem to be unitless values? - https://en.wikipedia.org/wiki/Dilution_of_precision_(navigation). So not sure what to put there
There was a problem hiding this comment.
I believe you are correct.
| if (msg.flags & 0x07) != 0 { | ||
| self.table.insert( | ||
| ROLL, | ||
| format!("{: >6.2} deg", ((msg.roll as f64) * UDEG2DEG)), |
There was a problem hiding this comment.
Removed all the degs because the unit ([°]) was added to the left column
|
The ticket also mentioned adding seconds to TOW, but skipped that one because isn't TOW by definition the number of seconds into the GPS week? Happy to add it, just seemed redundant |
console_backend/src/constants.rs
Outdated
| pub(crate) const ROLL: &str = "Roll [°]"; | ||
| pub(crate) const PITCH: &str = "Pitch [°]"; | ||
| pub(crate) const YAW: &str = "Yaw [°]"; | ||
| pub(crate) const ROLL_ACC: &str = "Roll Acc [°]"; |
There was a problem hiding this comment.
We need to merge these Roll (Acc) pitch/yaw like we did for the bobcat release:
https://github.com/swift-nav/piksi_tools/blob/2e0cb4d24d583c6fb3eabf66cbc125a3c01f26c5/piksi_tools/console/solution_view.py#L600
It never made it into the new console; however, I'm not sure how the units should be appended. I guess just do what ever looks better and we can change it later if needed. Sorry for the confusion
There was a problem hiding this comment.
Ahh right, well I have it like this currently (truncated the fields to match the old console) Speaking of I'm guessing we're gonna want to truncate LLH fields, but they aren't in the old console so not sure what to cut it off at
🤷♂️ |
2 participants
No description provided.