Skip to content

python trailing newlne linter/formatter #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2021
Merged

python trailing newlne linter/formatter #31

merged 4 commits into from
Apr 15, 2021

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Apr 15, 2021 •
edited
Loading

Python (hopefully cross platform) solution for fixing up trailing newlines.

If there are trailing newlines, running cargo make newline-check you'll see:

... cargo make output ...
*********************************************
*** ERROR: files missing trailing newline ***
*********************************************
.gitattributes
*********************************************
... cargo make output ...

Then you can run cargo make newline-format to fix.

jayvdb
jayvdb approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like perl but worth merging to keep as an example of what is possible.
I wonder if cargo-make author might be interested in adding stuff to duckscript sdk to make this easy.

@silverjam silverjam merged commit a9b6175 into john-michaelburke/PR29-extras Apr 15, 2021
@silverjam silverjam deleted the silverjam/newline-terminator branch April 15, 2021 06:19
john-michaelburke added a commit that referenced this pull request Apr 15, 2021
@john-michaelburke
PR29 Extra reviews. (#30)
41a0e6a 
* john-michaelburke/PR29-extras

* Added a command to check/fix newline for specific file types.

* python trailing newlne linter/formatter (#31)

* python trailing newlne linter/formatter

* fix-up

* private = true

* remove newline check

* remove linelint config

* Respond to review requests.

* Fix GAL_E8 strings.

Co-authored-by: Jason Mobarak <[email protected]>
Co-authored-by: Jason Mobarak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@john-michaelburke john-michaelburke Awaiting requested review from john-michaelburke

1 more reviewer

@jayvdb jayvdb jayvdb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@silverjam @jayvdb