Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jan 1, 2022

Implements

  • Reverted the buttons in the settings pane to grid layout and have auto survey always visible but not enabled until select "survey position" category. (A tooltip instructs the user to select field from surveyed_position)
  • Switched settings pane details to grid layout and added word wrapping as well as a scrollbar.

Concerns

  • Had to implement some interesting scaling for the "Value" field which may require some additional tuning based on feedback from others.
  • The flickable scroll buffer is hardcoded and always present so it may not scale well.
  • Now the "Value" field extends the entire width of the app to simplify logic. To be fair this is how it was implemented in the old app.
  • Needed to add a sleep to the CPU benchmark to prevent a fairly consistent segfault. I don't know how or what in this PR would require this all I can assume is it is related to a file not fully closing before the next bench iteration runs. 🤷 . Maybe this will resolve CPP-127.

Screen Shot 2021-12-31 at 7 29 51 PM

Layout.alignment: Qt.AlignHCenter | Qt.AlignVCenter
padding: parent.buttonPadding
text: "Auto Survey\n"
enabled: selectedRowField("group") === "surveyed_position"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this from visible to enable to make it easier to arrange buttons.

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/settings-panel-elide branch from 8101107 to 58e6a89 Compare January 1, 2022 18:10
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/settings-panel-elide branch from edbb16f to 24a852b Compare January 1, 2022 21:18
@john-michaelburke john-michaelburke marked this pull request as ready for review January 2, 2022 03:18
@john-michaelburke john-michaelburke requested a review from a team January 2, 2022 03:18
@john-michaelburke john-michaelburke merged commit c1b53b8 into main Jan 2, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/settings-panel-elide branch January 2, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants