Fix broken --tab command line option[CPP-568] #332
Conversation
resources/TabInfoBar.qml
Outdated
| Layout.fillWidth: false | ||
| spacing: 1 | ||
| onCountChanged: { | ||
| if (Globals.initialSubTabIndex > -1 && count == tabBarRepeater.count) { |
There was a problem hiding this comment.
This seems a little strange. The tabBars local count seems to increment up to the expected where as tabBarRepeater's count will be the max expected. Using onCompleted happens before all tabButtons seem to complete.
There was a problem hiding this comment.
onCompleted - are you speaking of the onCompleted within TabBar?
Maybe try putting the onCompleted within the Repeater? Still, it does seem odd that it happens before all tabButtons are created.
There was a problem hiding this comment.
Yeah the Repeater triggers the onCompleted before any of the tab buttons are created and only once. I found using onModelChanged seems to trigger after all the tab buttons have been completed so it seems like a decent choice.
There was a problem hiding this comment.
Have you tried a Component.onCompleted on the TabBar instead of the repeater?
There was a problem hiding this comment.
Yeah it appears to complete before the model is populated as well.
john-michaelburke
deleted the
john-michaelburke/fix-subtab-selection-from-cli
branch
2 participants
Fixes issue with correct subtab showing when you use the
tabcli arg. For example:cargo make run --tab TRACKING_SKYPLOT