Fix importing ntrip settings [CPP-448] #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
console_backend/src/settings_tab.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn sort_import_group<'a>( |
There was a problem hiding this comment.
I think we should use "reorganize" instead of "sort" and a description of why we must reorganize in the docstring. For now I think this is fine but longer term I'm not sure if the console is the correct location for these conditionals maybe better off in one of our settings repos.
There was a problem hiding this comment.
Hmm yeah maybe add a write_all function to the settings client that handles this kind of stuff.
There was a problem hiding this comment.
Recorded here - https://swift-nav.atlassian.net/browse/DEVINFRA-603
john-michaelburke
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was during an import
ntrip.enablewould get written before the other settings, so if the config file hadntrip.enable=Trueyou'd get an error trying to writeusernameetc. This change writes that setting last (same forethernet.interface_modetoo, maybe there are more like this?). It also adds a little context to the error message during an import