Silence error sending msg over udp[CPP-489] #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if let Err(err) = client.send(&frame) { | ||
| error!("Error sending to device: {}", err); | ||
| } | ||
| if let Err(_e) = client.send(&frame) {} |
There was a problem hiding this comment.
Not sure if there is an accepted way to beat the linter for "not handling" a result. Surprisingly difficult task as it was suggesting options that it would then flag.
There was a problem hiding this comment.
Can we put a comment within the if that says we're intentionally squelching the error?
john-michaelburke
changed the title
silverjam
approved these changes
Jan 7, 2022
| if let Err(err) = client.send(&frame) { | ||
| error!("Error sending to device: {}", err); | ||
| } | ||
| if let Err(_e) = client.send(&frame) {} |
There was a problem hiding this comment.
Can we put a comment within the if that says we're intentionally squelching the error?
silverjam
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std::net::UdpSocket we are using implements a nontraditional version of udp with a connection. "Although UDP is a connectionless protocol, this implementation provides an interface to set an address where data should be sent and received from." https://doc.rust-lang.org/std/net/struct.UdpSocket.html