Always create initial logging directory.[CPP-407] #345
Conversation
john-michaelburke
force-pushed
the
john-michaelburke/CPP-407
branch
2 times, most recently
from
96d65b5 to
6671d54
Compare
john-michaelburke
force-pushed
the
john-michaelburke/CPP-407
branch
from
6671d54 to
6aef1b3
Compare
john-michaelburke
changed the title
| Some(logger) | ||
| } | ||
| Err(e) => { | ||
| error!("issue creating file, {:?}, error, {}", sbp_log_file, e); |
There was a problem hiding this comment.
Not 100% certain but I think the double slashes are due to using the Debug to format the path. I think using Path::display would give you single slashes.
error!("issue creating file, {}, error, {}", sbp_json_log_file.display(), e);
There was a problem hiding this comment.
You were 100% correct this make for a much cleaner solution thank you!
console_backend/src/utils.rs
Outdated
|
|
||
| /// Formats a pathbuf replacing double backslahes with single forward slashes. | ||
| pub fn pathbuf_to_unix_filepath(path: PathBuf) -> PathBuf { | ||
| PathBuf::from(path.to_string_lossy().replace("\\", "/")) |
There was a problem hiding this comment.
Forward slashes are not the typical path separator for Windows. Whatever we implement should display a single backslash for Windows.
There was a problem hiding this comment.
I believe that is the behavior of Path::display, single forward slash on unix and single backslash on windows. I think the double slash is just the Debug impl showing you the escape character
There was a problem hiding this comment.
I switched to using .display for all occurrences I could find throughout the app.
john-michaelburke
force-pushed
the
john-michaelburke/CPP-407
branch
from
1a00fb4 to
4997a36
Compare
3 participants
Uh oh!
There was an error while loading. Please reload this page.