Skip to content

Update tab use base types and minor UI cleanup[CPP-499][CPP-506] #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

Update tab use base types and minor UI cleanup[CPP-499][CPP-506] #359

merged 1 commit into from
Jan 12, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jan 11, 2022 •
edited
Loading

  • Makes a SwiftTextbox and SwiftTextInput type to standardize and abstract most of the formatting.
  • Everything else is mostly just converting all text boxes and text inputs to these abstract types.

Comparison below: New vs Old
Screen Shot 2022-01-11 at 11 15 27 AM

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/CPP-499 branch from 3f2d984 to bc3a526 Compare January 11, 2022 19:27
@john-michaelburke john-michaelburke requested a review from a team January 11, 2022 20:42
@john-michaelburke john-michaelburke marked this pull request as ready for review January 11, 2022 20:45
@john-michaelburke john-michaelburke merged commit fe2c85f into main Jan 12, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/CPP-499 branch January 12, 2022 19:14
@silverjam silverjam mentioned this pull request Mar 22, 2022
Merged
@silverjam silverjam mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam