Skip to content

Fix issues with Update Notifications.[CPP-569][CPP-586] #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2022
Merged

Fix issues with Update Notifications.[CPP-569][CPP-586] #366

merged 3 commits into from
Jan 17, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jan 14, 2022 •
edited
Loading

  • Move firmware and console version updates to top layer of app. Fixes issue where notifications would open in top left corner.
  • Adds a "no-prompts" cli command to disable update notification prompts while the app runs.
  • Clear firmware notification prompt status after connection drops.
  • Fixes issue where performing/initiating an update on a serial device then switching to a tcp device and upgrading would open the "Serial 30+ min warning" prompt.
  • Reworks the no-opengl cli arg to use-opengl. Where the default behavior is disabled.

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/fix-update-notifications branch from 7492a5e to 0a1968a Compare January 15, 2022 00:29
john-michaelburke
john-michaelburke commented Jan 15, 2022
View reviewed changes
resources/UpdateNotifications.qml

Layout.fillWidth: true
wrapMode: Text.Wrap
text: `Please visit <a href='${website}'>${websiteDisplay}</a> to download the latest version.\n\n`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to split this into multiple labels to get this href too work for some reason.

@john-michaelburke john-michaelburke marked this pull request as ready for review January 15, 2022 00:52
@john-michaelburke john-michaelburke requested a review from a team January 15, 2022 01:08
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/fix-update-notifications branch from 0a1968a to aea7016 Compare January 15, 2022 06:17
@john-michaelburke john-michaelburke merged commit 4795120 into main Jan 17, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/fix-update-notifications branch January 17, 2022 00:49
@silverjam silverjam mentioned this pull request Mar 22, 2022
Merged
@silverjam silverjam mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam