Fix time axis of IMU and magnetometer plots [CPP-602] #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flips the x axis labels of IMU messages, so that the most recent sample is labelled 0 and the oldest is labelled 200. Previously, this was vice-versa.
|
I think all other charts start from the right side and scroll to the left so it would be somewhat inconsistent. If you do go ahead with it then we should put the legend on the right side because it looks like it covers the data within the first 25 seconds or so. |
Fair enough! Have reversed the X axis in both now. So this is the current implemented functionality:
|
john-michaelburke
approved these changes
Jan 19, 2022
silverjam
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flips the x axis labels of IMU messages, so that the most recent sample
is labelled 0 and the oldest is labelled 200. Previously, this was
vice-versa.
This doesn't exactly flip the X axis, but it's what makes the most sense to me and is what I'm guessing was the intention of the requested flip? To me, it makes sense if the plot moves left to right and the most recent sample is shown at 0. Maybe I'm thinking about it differently? Happy to actually swap the axis if that's what's preferred.
What I've implemented
With the X axis reversed
Current implementation in
main(for reference)