Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

  • Removes the 1 second timer that would write settings.
  • Adds a mouseover to the bottom right pane to catch deselect.

@keithel-qt Would you have a better suggestion for checking when our "textField" loaded component should lose focus by clicking away from the textField? Seems like the entire app would need to be wrapped in a mousearea with this approach I'm taking.

Screen.Recording.2022-01-20.at.7.16.46.PM.mov

Copy link
Contributor

@keithel-qt keithel-qt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - I have some recommendations now.

  • Remove your MouseArea that covers the entirety of the SettingsPane
  • Replace with MouseArea in the Labels.
  • Use forceActiveFocus() instead of setting focus to false - as something should always have activeFocus, and I'm not sure what would have activeFocus if you just set the focus to false.
  • Remove textFieldFocus property you created, since it will no longer be used.

Comment on lines 329 to 340

MouseArea {
anchors.fill: parent
onPressed: {
mouse.accepted = false;
if (settingsPane.textFieldFocus.focus)
settingsPane.textFieldFocus.focus = false;

}
onClicked: mouse.accepted = false
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.
Instead we will put MouseArea on the Labels. in SettingsPane.

Inside of each Label (inside of settingRowLabel and settingRowText) put the following MouseArea:

MouseArea {
    anchors.fill: parent
    onClicked: parent.forceActiveFocus();
}

Copy link
Collaborator Author

@john-michaelburke john-michaelburke Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The apps team was not in to the Save button. I add your suggestion to the Labels as well as the pane above where the buttons are located. Seems sufficient to me.
Screen Shot 2022-01-24 at 2 42 35 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants