Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jan 26, 2022

Shorten Application NameCPP-580
Unify name of console packageCPP-578
Change AppData locationCPP-421
Installer doesn't warn when upgradingCPP-415
Adds check for Windows10+.
Adds warning for installing MSVC Redist package if not found before installing.
Adds metadata to linux debian.
Parameterized the app name in the github actions yaml and our Makefile if we choose to change the name again for whatever reason 😄

Here is a test release containing the changes: https://github.com/swift-nav/swift-toolbox/releases/tag/0.16.1-test

Screen Shot 2022-01-26 at 3 27 11 PM

Screen Shot 2022-01-26 at 3 27 51 PM

Linux .deb metadata:

jm@ubuntu:~/Downloads$ apt-cache show ./swift-console_0.16.1-test_linux.deb 
Package: swift-console
Version: 0.16.1-test
License: unknown
Vendor: none
Architecture: amd64
Maintainer: Swift Navigation <https://www.swiftnav.com/support>
Installed-Size: 335462
Depends: libxcb-xinerama0
Section: default
Priority: extra
Homepage: https://www.swiftnav.com
Description: The Swift Console is a Graphic User Interface (GUI) program providing visual representation of what's happening inside the Swift Navigation GNSS receivers. Console displays information and allows to adjust the settings on the hardware.
Description-md5: 9eba55915da60495e344fe1eae89af0c
Filename: /home/jm/Downloads/swift-console_0.16.1-test_linux.deb
Size: 110545596

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/name-unification branch from bc9958d to 0fbd6ee Compare January 26, 2022 22:17
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/name-unification branch from 0fbd6ee to c2fd385 Compare January 26, 2022 22:20
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/name-unification branch from c2fd385 to f6ad299 Compare January 26, 2022 22:37
@john-michaelburke john-michaelburke changed the title John michaelburke/name unification Unify application and installer names, polish installers. Jan 26, 2022
@john-michaelburke john-michaelburke marked this pull request as ready for review January 27, 2022 00:23
@john-michaelburke john-michaelburke requested a review from a team January 27, 2022 00:24
Copy link
Contributor

@notoriaga notoriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be changed?

@john-michaelburke
Copy link
Collaborator Author

I think these need to be changed?

Updated the bin names, fixed Windows bin name it is the same as unix + .exe. Also added a description in the about for the CLI. Same as the description used in the linux deb metadata. Looks like this:

Swift Console 0.16.1-test
The Swift Console is a Graphic User Interface (GUI) program providing visual representation of
what's happening inside the Swift Navigation GNSS receivers. Console displays information and allows
to adjust the settings on the hardware.

USAGE:
    swift-console [OPTIONS] [SUBCOMMAND]
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants