Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

  • Fixes issue when user would have Advanced settings shown, scroll all the way to the bottom, then uncheck Advanced. The scrollbar would be out of bounds. This will reset it to the correct location in this situation.
  • Fixed issue with flakey dropdowns after more than one change. When checking if the value on the device is the same as the proposed change it was comparing with a copy of the value instead of a pointer. I refactored the logic so it will always evaluate based off a pointer to the element.
  • Fixed some flakey advanced settings flakiness. Now instead of relying on a callback to trigger showing advanced settings it points to a pointer to the buttons checked property.
  • Also decided to revert back to the Settings Table clearing between connections to prevent a few new bugs observed that I am having trouble replicating.

@john-michaelburke john-michaelburke marked this pull request as ready for review January 28, 2022 23:50
@john-michaelburke john-michaelburke requested a review from a team January 29, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants