-
Notifications
You must be signed in to change notification settings - Fork 2
[CPP-53]Create github actions for building installer. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfce4ca
to
f9c92a9
Compare
ab792b9
to
2d9d16d
Compare
2d9d16d
to
e767bc7
Compare
silverjam
reviewed
Feb 11, 2021
silverjam
reviewed
Feb 11, 2021
silverjam
reviewed
Feb 11, 2021
silverjam
reviewed
Feb 11, 2021
silverjam
reviewed
Feb 11, 2021
silverjam
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like python lint needs some love but otherwise lgtm
945a71d
to
e5ef8f2
Compare
silverjam
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added python format/lint/type-check/(pytest will be added later on) commands to Makefile.toml.
Added rust format/lint/unittest commands to Makefile.
Adds github action instruction for Linux CD, Mac CD and Linux CI.
The Linux CI includes all checks for Python and Rust.
The Linux CD uses the original FBS approach but there has also been some development on Linux Nuitka (currently builds but no mechanism set up for creating a .deb file).
The Mac CD uses nuitka approach and currently the end result is not signed so it will likely not run unless you follow the process locally. (Verified locally on BigSur and Catalina?(whichever is before BigSur).
Windows CD will come in the next PR. The other checkpoint PR will be rebased/adapted to this PRs implementation.