Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Feb 3, 2021

Added python format/lint/type-check/(pytest will be added later on) commands to Makefile.toml.
Added rust format/lint/unittest commands to Makefile.
Adds github action instruction for Linux CD, Mac CD and Linux CI.
The Linux CI includes all checks for Python and Rust.

The Linux CD uses the original FBS approach but there has also been some development on Linux Nuitka (currently builds but no mechanism set up for creating a .deb file).
The Mac CD uses nuitka approach and currently the end result is not signed so it will likely not run unless you follow the process locally. (Verified locally on BigSur and Catalina?(whichever is before BigSur).

Windows CD will come in the next PR. The other checkpoint PR will be rebased/adapted to this PRs implementation.

@john-michaelburke john-michaelburke force-pushed the johnmichael-burke/github-actions branch 30 times, most recently from dfce4ca to f9c92a9 Compare February 5, 2021 18:30
@john-michaelburke john-michaelburke force-pushed the johnmichael-burke/github-actions branch 14 times, most recently from ab792b9 to 2d9d16d Compare February 11, 2021 21:37
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like python lint needs some love but otherwise lgtm

@john-michaelburke john-michaelburke force-pushed the johnmichael-burke/github-actions branch from 945a71d to e5ef8f2 Compare February 12, 2021 01:33
@john-michaelburke john-michaelburke merged commit b27edce into main Feb 12, 2021
@john-michaelburke john-michaelburke deleted the johnmichael-burke/github-actions branch February 12, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants