Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

To prepare for running our Windows installer on the code signer runner, we need to refine our labelling for the machines available to the frontend benchmark stage. I also added labels to the bench machines accordingly.

@john-michaelburke john-michaelburke requested a review from a team February 1, 2022 22:07
@john-michaelburke john-michaelburke enabled auto-merge (squash) February 1, 2022 22:09
@silverjam
Copy link
Contributor

To prepare for running our Windows installer on the code signer runner, we need to refine our labelling for the machines available to the frontend benchmark stage. I also added labels to the bench machines accordingly.

Note we should still be able to build the installer where it's currently being built, we just need to sign the installer on the code-signer machine.

@john-michaelburke
Copy link
Collaborator Author

john-michaelburke commented Feb 1, 2022

To prepare for running our Windows installer on the code signer runner, we need to refine our labelling for the machines available to the frontend benchmark stage. I also added labels to the bench machines accordingly.

Note we should still be able to build the installer where it's currently being built, we just need to sign the installer on the code-signer machine.

Yes I'm trying to mull this over right now. I think if we need to sign the files in addition to the installer we will need to break things up a bit though correct? I see your comment in slack, so then yes if all we need to sign is the installer it should not be a huge change.

@silverjam
Copy link
Contributor

To prepare for running our Windows installer on the code signer runner, we need to refine our labelling for the machines available to the frontend benchmark stage. I also added labels to the bench machines accordingly.

Note we should still be able to build the installer where it's currently being built, we just need to sign the installer on the code-signer machine.

Yes I'm trying to mull this over right now. I think if we need to sign the files in addition to the installer we will need to break things up a bit though correct? I see your comment in slack, so then yes if all we need to sign is the installer it should not be a huge change.

Yeah, I think we can do things in stages, let's start with just signing the installer, if we need to sign individual files we can revisit later.

@john-michaelburke john-michaelburke merged commit d868d39 into main Feb 1, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/use-bench-label-sh-runners branch February 1, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants