Skip to content

Parse tcp subcommand for host/port pair[CPP-637] #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Parse tcp subcommand for host/port pair[CPP-637] #408

merged 1 commit into from
Feb 4, 2022

Conversation

john-michaelburke
Copy link
Collaborator

  • Parse the TCP/IP subcommand for an optional format "host" or "host:port". If the latter is provided it would override any port provided via the port argument.
  • Also parse the arguments for help related args to prevent loading the qml app if help is requested.

Here is what the CLI looks like for TCP/IP now:
Screen Shot 2022-02-03 at 6 11 54 PM

@john-michaelburke john-michaelburke merged commit d297667 into main Feb 4, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/cpp-637 branch February 4, 2022 18:14
@silverjam silverjam mentioned this pull request Mar 22, 2022
Merged
@silverjam silverjam mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam