Skip to content

A few minor changes[CPP-619][CPP-610][CPP-662] #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2022
Merged

A few minor changes[CPP-619][CPP-610][CPP-662] #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e528b
SwiftTableView cell padding, Update tab panel clip[CPP-619][CPP-622]
john-michaelburke Feb 15, 2022
443729f
Hardcode height of top tabinfobar[CPP-610]
john-michaelburke Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions resources/Constants/Constants.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ QtObject {
})
readonly property string infoButtonIconPath: "qrc:/images/fontawesome/info-circle-solid.svg"
readonly property color infoButtonIconColor: swiftLightGrey
readonly property int height: 50
}

logoPopup: QtObject {
Expand Down Expand Up @@ -261,6 +262,8 @@ QtObject {
genericTable: QtObject {
readonly property int headerZOffset: 100
readonly property int padding: 2
readonly property int leftPadding: 5
readonly property int rightPadding: 5
readonly property int borderWidth: 1
readonly property int mouseAreaResizeWidth: 10
readonly property int cellHeight: 25
Expand Down
3 changes: 2 additions & 1 deletion resources/SettingsTabComponents/SettingsTable.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ Rectangle {
font.bold: isHeaderRow(row)
text: model.display
elide: Text.ElideRight
padding: Constants.genericTable.padding
leftPadding: Constants.genericTable.leftPadding
rightPadding: Constants.genericTable.rightPadding
}

MouseArea {
Expand Down
3 changes: 2 additions & 1 deletion resources/TableComponents/SwiftTableView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ TableView {
font: tableFont
text: model.display
elide: Text.ElideRight
padding: Constants.genericTable.padding
leftPadding: Constants.genericTable.leftPadding
rightPadding: Constants.genericTable.rightPadding
}

MouseArea {
Expand Down
1 change: 1 addition & 0 deletions resources/UpdateTab.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ MainTab {
Layout.fillHeight: true
border.width: Constants.updateTab.borderWidth
border.color: Constants.genericTable.borderColor
clip: true

ScrollView {
anchors.fill: parent
Expand Down
1 change: 1 addition & 0 deletions resources/view.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ ApplicationWindow {
// be slid up "under" the window.
anchors.left: parent.left
anchors.right: parent.right
height: Constants.tabInfoBar.height
z: 2
tabName: sideNavBar.currentTabName
subTabNames: mainTabs.subTabNames
Expand Down