Skip to content

Convert all python globals to signal.emit updates[CPP-695] #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

Convert all python globals to signal.emit updates[CPP-695] #468

merged 2 commits into from
Mar 16, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Mar 16, 2022 •
edited
Loading

  • Converts all python pyside objects to use a signal emit approach

@john-michaelburke john-michaelburke marked this pull request as ready for review March 16, 2022 01:54
@john-michaelburke john-michaelburke requested a review from a team March 16, 2022 01:54
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/emit-updates branch from eab538d to bca1923 Compare March 16, 2022 17:06
@john-michaelburke john-michaelburke enabled auto-merge (squash) March 16, 2022 17:11
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/emit-updates branch from bca1923 to df76c61 Compare March 16, 2022 18:36
@john-michaelburke john-michaelburke merged commit 2b29898 into main Mar 16, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/emit-updates branch March 16, 2022 18:44
john-michaelburke added a commit that referenced this pull request Mar 22, 2022
@john-michaelburke
Revert "Convert all python globals to signal.emit updates[CPP-695] (#468
3ebc145 
)"

This reverts commit 2b29898.
john-michaelburke added a commit that referenced this pull request Mar 22, 2022
@john-michaelburke
Revert "Convert all python globals to signal.emit updates[CPP-695] (#468
4ce3332 
)" (#473)

This reverts commit 2b29898.
@silverjam silverjam mentioned this pull request Mar 22, 2022
Merged
@silverjam silverjam mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-michaelburke @silverjam