Context Receiver Logic -> Watched ConnectionState monitor handle thread. #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
steve/cpp-693
branch
from
9d95d95 to
079c13a
Compare
john-michaelburke
changed the title
john-michaelburke
approved these changes
Mar 30, 2022
notoriaga
commented
Mar 30, 2022
| if self.shared.is_closed() { | ||
| return Ok(Err(RecvError)); | ||
| } | ||
| let t = Instant::now(); |
There was a problem hiding this comment.
@john-michaelburke I pushed one small addition, I think we have to do the a similar thing with the timeout here in case the while loop runs more than once
There was a problem hiding this comment.
I don't think this will change anything as it should normally only happen once I think, not sure if you wanna give it a go before I merge this
There was a problem hiding this comment.
Tried it out on linux and windows. Looks good to me!
john-michaelburke
added a commit
that referenced
this pull request
Mar 31, 2022
…ad. (#491) Co-authored-by: John Michael Burke <[email protected]>
john-michaelburke
added a commit
that referenced
this pull request
Mar 31, 2022
…93] (#487) * Apply local settings timeouts, global read_all_settings timeout[CPP-693] * Context Receiver Logic -> Watched ConnectionState monitor handle thread. (#491) Co-authored-by: Steven Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.