Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Mar 31, 2022

  • Unifies font sizes between all operating systems. Seems Mac doesnt quite respect pointSize and as far as I can tell treats it as pixelSize. So this converts all usage of pointSize to pixelSize and now they look similar.
  • Adds a longtextfield check and multiplier to the "Description" section in Settings pane as a few were getting cut off. Checked most of them are now covered by this.
  • Removes the logic we had for adding a scalefactor to our fonts based on operating system and "no-high-dpi".
  • Also removes the pesky warning message: Both point size and pixel size set. Using pixel size.

Currently building a test release.

@john-michaelburke
Copy link
Collaborator Author

Here is a test release with the most recent changes:
swift-console_v4.0.3-pixelsize_linux.deb103 MB
swift-console_v4.0.3-pixelsize_macos.dmg63.9 MB
swift-console_v4.0.3-pixelsize_windows.exe

@john-michaelburke john-michaelburke requested a review from a team March 31, 2022 23:59
@silverjam silverjam requested review from a team and keithel-qt April 1, 2022 03:05
@john-michaelburke john-michaelburke merged commit ff98ee3 into main Apr 1, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/pixel-size branch April 1, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants