[CPP-61]Checkpoint rebase with filein and tracking points(buggy). #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
changed the title
| ListElement { | ||
| name: "John Brown" | ||
| number: "555 8426" | ||
| } |
There was a problem hiding this comment.
This file is a place holder for what will eventually become the Solution Live Table pane.
silverjam
reviewed
Feb 12, 2021
silverjam
approved these changes
Feb 12, 2021
|
@john-michaelburke FYI @notoriaga is out on PTO until Tuesday, so up to you if you want to go ahead and merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pulling in all the changes from #3 as rebasing was too messy.
I also went through and fixed all the suggestions you had @silverjam .
This does not fix the bug in tracking points, I think that will require some merging of time parsing from ICBINS.
This also shows that the QML files can be directly imported from another QML file as long as the file is present in the top level resources folder ( where view.qml is currently located).