Include exit-after-secs to CLI. #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftnav_console/main.py
Outdated
|
|
||
| def main(passed_args: Optional[Tuple[str, ...]] = None) -> int: | ||
| parser = argparse.ArgumentParser(add_help=False, usage=argparse.SUPPRESS) | ||
| parser = argparse.ArgumentParser(add_help=False, usage=argparse.SUPPRESS, allow_abbrev=False) |
There was a problem hiding this comment.
The allow_abbrev is needed because python is catching our "exit-after" flag that is only consumed by the backend thinking it is a typo. Maybe we should use a different name here?
There was a problem hiding this comment.
How about --exit-after-timeout and --exit-after-close (for the existing --exit-after)?
john-michaelburke
force-pushed
the
john-michaelburke/exit-after-secs
branch
from
c8eacee to
0d91f74
Compare
silverjam
approved these changes
Apr 20, 2022
keithel-qt
added a commit
that referenced
this pull request
Apr 26, 2022
cherry-picked to crash inspection branch. This also reverts "Add exit-after-secs cmdline option to console" commit 1cfdba6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using this feature quite a bit attempting to debug the intermittent crash. So I am taking it from @keithel-qt PR:
#512