Update to reflect new GpsTime changes. #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
requested review from
jayvdb,
notoriaga and
silverjam
and removed request for
silverjam
notoriaga
reviewed
May 11, 2021
| let mut main = MainTab::new(shared_state.clone(), client_send); | ||
| let messages = strip_errors_iter(true, messages); | ||
| for message in messages { | ||
| for message_and_time in messages { |
There was a problem hiding this comment.
You can unpack the tuple in the for loop too if you want
Suggested change
| for message_and_time in messages { | |
| for (message, gps_time) in messages { |
| /// | ||
| /// # Parameters | ||
| /// - `gps_time`: The GpsTime corresponding to a message. | ||
| pub fn realtime_delay<T>(&mut self, gps_time: Option<Result<GpsTime, T>>) { |
There was a problem hiding this comment.
I think you can replace this generic param with sbp::time::GpsTimeError
Suggested change
| pub fn realtime_delay<T>(&mut self, gps_time: Option<Result<GpsTime, T>>) { | |
| pub fn realtime_delay(&mut self, gps_time: Option<Result<GpsTime, GpsTimeError>>) { |
There was a problem hiding this comment.
Hmm maybe not actually, looks like it breaks some of the tests
There was a problem hiding this comment.
Yeah I think I may be stuck with the generic?
Comment on lines
+13
to
+14
| pub fn process_messages<S: MessageSender, T>( | ||
| messages: impl Iterator<Item = (SBP, Option<std::result::Result<GpsTime, T>>)>, |
There was a problem hiding this comment.
Same with this one
Suggested change
| pub fn process_messages<S: MessageSender, T>( | |
| messages: impl Iterator<Item = (SBP, Option<std::result::Result<GpsTime, T>>)>, | |
| pub fn process_messages<S: MessageSender>( | |
| messages: impl Iterator<Item = (SBP, Option<std::result::Result<GpsTime, GpsTimeError>>)>, |
notoriaga
approved these changes
May 11, 2021
john-michaelburke
force-pushed
the
update_libsbp_dep
branch
from
6171b0a to
89603d7
Compare
notoriaga
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uprevved libsbp dependency to reflect new GpsTime changes.