splash screen with a version [CPP-767] #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 31, 2022 14:31
Makefile.toml
Outdated
| [tasks.install-imagemagick] | ||
|
|
||
| [tasks.install-imagemagick.windows] | ||
| script = "scoop install imagemagick" |
There was a problem hiding this comment.
Is there a certain reason you are using scoop? It looks like imagemagick might be available via Choco which is already installed on GitHub runners:
choco install imagemagick.app
There was a problem hiding this comment.
scoop doesn't require admin privs to install packages so it's a little easier when trying to run the install target on Winows, but you're correct: choco works better with CI... so I'll drop scoop
added 20 commits
May 31, 2022 17:32
silverjam
changed the title
|
Note sure why there are red Xs on the last commit, but there's clean build of everything here at least: https://github.com/swift-nav/swift-toolbox/actions/runs/2424923017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://swift-nav.atlassian.net/browse/CPP-767
Adds a version number to the splash screen per request from apps.
Uses ImageMagick to automate. Customer installation of ImageMagick implemented here: https://github.com/swift-nav/swift-toolchains/tree/master/imagemagick
Example build here: https://github.com/swift-nav/swift-toolbox/releases/tag/v4.0.7-splashversion