Remove use of MetricsMonitor in the app #581
Conversation
|
@samvrlewis Do you have any context of this? It looks like this is touching CSAC stuff? |
Not really - the only thing I could find is this: https://snav.slack.com/archives/C020JLK6PK8/p1632357172054400 . |
There was a problem hiding this comment.
Removing from my review queue for now -- will defer to @john-michaelburke to make a decision on this, there may be unimplemented features that we need to follow up on
|
The metrics monitor was used to display some experimental Csac telemetry data as a one off for some customer and has been deprecated for a long time. Unfortunately, this was not conveyed until it was implemented in the new console. So removing this works with me. I created a PR to merge into this that additionally removes all the csac telemetry references. |
MetricsMonitor is never enabled, and is just there causing QML warning messages for no reason. The warnings could be fixed, but there is no way to test them at present, so, for now, just disable use of it in the app. Leave the MetricsMonitor.qml present, but don't package it with the app (leave it out of console_resources.qrc). When it is to be re-enabled, then it can be fixed up and re-tested.
john-michaelburke
force-pushed
the
keithel-qt/remove-metrics-monitor
branch
from
1fd8f3e to
cf06355
Compare
|
Ok - with J-M's PR to this branch, I think this should be all set. |
4 participants
MetricsMonitor is never enabled, and is just there causing QML warning messages
for no reason. The warnings could be fixed, but there is no way to test them at
present, so, for now, just disable use of it in the app. Leave the
MetricsMonitor.qml present, but don't package it with the app (leave it out of
console_resources.qrc).
When it is to be re-enabled, then it can be fixed up and re-tested.