Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Jun 3, 2022

Jira: https://swift-nav.atlassian.net/browse/CPP-768

Test build of the installers here: https://github.com/swift-nav/swift-toolbox/releases/tag/v4.0.7-installer-size

Should help to fix a regression in the size of the installers for Windos. This removes debug DLLs that get populated in the PySide2 wheel (which end up in our installer).


After change:

❯ fd -I --glob '*d.dll'
Lib\site-packages\PySide2\Qt5Gamepad.dll
Lib\site-packages\PySide2\plugins\gamepads\xinputgamepad.dll
Lib\site-packages\PySide2\plugins\platforms\qdirect2d.dll
Lib\site-packages\PySide2\plugins\renderplugins\scene2d.dll
Lib\site-packages\PySide2\plugins\scenegraph\qsgd3d12backend.dll

Before change:

❯ fd -I --glob '*d.dll'
Lib\site-packages\PySide2\Qt5Chartsd.dll
Lib\site-packages\PySide2\Qt5Concurrentd.dll
Lib\site-packages\PySide2\Qt5Cored.dll
Lib\site-packages\PySide2\Qt5DBusd.dll
Lib\site-packages\PySide2\Qt5Gamepad.dll
Lib\site-packages\PySide2\Qt5Gamepadd.dll
Lib\site-packages\PySide2\Qt5Guid.dll
Lib\site-packages\PySide2\Qt5Helpd.dll
Lib\site-packages\PySide2\Qt5MultimediaQuickd.dll
Lib\site-packages\PySide2\Qt5MultimediaWidgetsd.dll
Lib\site-packages\PySide2\Qt5Multimediad.dll
Lib\site-packages\PySide2\Qt5Networkd.dll
Lib\site-packages\PySide2\Qt5OpenGLd.dll
Lib\site-packages\PySide2\Qt5PositioningQuickd.dll
Lib\site-packages\PySide2\Qt5Positioningd.dll
Lib\site-packages\PySide2\Qt5PrintSupportd.dll
Lib\site-packages\PySide2\Qt5QmlModelsd.dll
...

@silverjam silverjam changed the title remove windows debug libraries remove windows debug libraries [CPP-768] Jun 3, 2022
@silverjam silverjam requested review from notoriaga and samvrlewis June 3, 2022 01:06
@silverjam
Copy link
Contributor Author

New installer sizes:

image


Old installer sizes:

image

@silverjam silverjam merged commit 97a7c9e into main Jun 3, 2022
@silverjam silverjam deleted the silverjam/remove-win-debug branch June 3, 2022 02:13
@silverjam silverjam changed the title remove windows debug libraries [CPP-768] installer size regression: remove windows debug libraries [CPP-768] Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants