-
Notifications
You must be signed in to change notification settings - Fork 2
Relax minimum width and default [CPP-423] #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is obviously a lot better than then previous 1050 width . Tracking looks good. Were you able to check all the other tabs to make sure they look fine as well ? |
@RaiBearG The only place this doesn't look that great is on the advanced tab, and I think it still looks OK |
@RaiBearG Added a small spacer to prevent the logo from colliding with the |
@silverjam Notice, in the Advanced tab the "console info" button disappears. |
Yeah, I think that's a reasonable behavior, if we can't fit things into the space available, they need to start disappearing or shrinking. |
We don't really have time right now to implement something fancier, this is a "better than nothing" change. |
sounds reasonable to me. does the info button disappear or is it just hidden , and if you manually make the console bigger it comes back ? |
some other notes : everything else looks good |
It's hidden and it'll come back if you expand the size |
I'll see if there's a small change I can do to make this look better. |
@RaiBearG Let me know how this looks: |
bfbe96c
to
b4884e8
Compare
looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rearranging carriage returns seems to do the trick.
This relaxes the minimum width that we allow to 900, which is the minimum that we can go down to such that the check boxes will not start overflowing and getting cut off.