Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Jun 8, 2022

This relaxes the minimum width that we allow to 900, which is the minimum that we can go down to such that the check boxes will not start overflowing and getting cut off.

image

@silverjam silverjam requested a review from RaiBearG June 8, 2022 21:18
@RaiBearG
Copy link

RaiBearG commented Jun 8, 2022

This is obviously a lot better than then previous 1050 width . Tracking looks good. Were you able to check all the other tabs to make sure they look fine as well ?

@silverjam
Copy link
Contributor Author

Screenshot 2022-06-08 145838
Screenshot 2022-06-08 145815
Screenshot 2022-06-08 145759
Screenshot 2022-06-08 145742
Screenshot 2022-06-08 145722
Screenshot 2022-06-08 145657
Screenshot 2022-06-08 145558
Screenshot 2022-06-08 145536
Screenshot 2022-06-08 144733
Screenshot 2022-06-08 143048
Screenshot 2022-06-08 143030
Screenshot 2022-06-08 143015
Screenshot 2022-06-08 142957

@silverjam
Copy link
Contributor Author

@RaiBearG The only place this doesn't look that great is on the advanced tab, and I think it still looks OK

@silverjam
Copy link
Contributor Author

@RaiBearG Added a small spacer to prevent the logo from colliding with the INS tab

Screenshot 2022-06-08 151437

@RaiBearG
Copy link

RaiBearG commented Jun 8, 2022

@silverjam Notice, in the Advanced tab the "console info" button disappears.

@silverjam
Copy link
Contributor Author

silverjam commented Jun 8, 2022

@silverjam Notice, in the Advanced tab the "console info" button disappears.

Yeah, I think that's a reasonable behavior, if we can't fit things into the space available, they need to start disappearing or shrinking.

@silverjam
Copy link
Contributor Author

@silverjam Notice, in the Advanced tab the "console info" button disappears.

Yeah, I think that's a reasonable behavior, if we can't fit things into the space available, they need to start disappearing or shrinking.

We don't really have time right now to implement something fancier, this is a "better than nothing" change.

@RaiBearG
Copy link

RaiBearG commented Jun 8, 2022

sounds reasonable to me. does the info button disappear or is it just hidden , and if you manually make the console bigger it comes back ?

@RaiBearG
Copy link

RaiBearG commented Jun 8, 2022

some other notes :
settings tab = the "Auto Survey" is cut off . again as long as it shows up when the app gets bigger, I am fine with that
settings tab = the "refresh from device" touches the refresh icon, can we add a space to that as well please.

everything else looks good

@silverjam
Copy link
Contributor Author

sounds reasonable to me. does the info button disappear or is it just hidden , and if you manually make the console bigger it comes back ?

It's hidden and it'll come back if you expand the size

@silverjam
Copy link
Contributor Author

some other notes :

settings tab = the "Auto Survey" is cut off . again as long as it shows up when the app gets bigger, I am fine with that

settings tab = the "refresh from device" touches the refresh icon, can we add a space to that as well please.

I'll see if there's a small change I can do to make this look better.

@silverjam
Copy link
Contributor Author

silverjam commented Jun 9, 2022

@RaiBearG Let me know how this looks:

Screenshot 2022-06-08 221348

@silverjam silverjam force-pushed the silverjam/min-width branch from bfbe96c to b4884e8 Compare June 9, 2022 05:14
@RaiBearG
Copy link

RaiBearG commented Jun 9, 2022

looks good.

Copy link

@RaiBearG RaiBearG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rearranging carriage returns seems to do the trick.

@silverjam silverjam enabled auto-merge (squash) June 9, 2022 05:49
@silverjam silverjam merged commit ca2e699 into main Jun 9, 2022
@silverjam silverjam deleted the silverjam/min-width branch June 9, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants