Skip to content

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jul 1, 2022

  • When opening the Update tab, instead of the "firmware file" auto-populating, it is now blank. If the user hits download firmware or selects an existing file then it will populate as normal.
  • When a user records a new SBP or SBP-JSON file, a full-settings refresh will occur such that if a customer uploads a file when submitting a ticket we can ensure the settings of their device will be included in the file.

@john-michaelburke john-michaelburke requested a review from a team July 1, 2022 22:36
@silverjam
Copy link
Contributor

Do we have Jira issues for these requests? Does Rai and the release team want to port these to the v4.0.0 branch, if these changes require UAT, then it will potentially delay the launch again.

@john-michaelburke john-michaelburke changed the title Few minor fixups. Few minor fixups.[CPP-785][CPP-786] Jul 1, 2022
@john-michaelburke
Copy link
Collaborator Author

Do we have Jira issues for these requests? Does Rai and the release team want to port these to the v4.0.0 branch, if these changes require UAT, then it will potentially delay the launch again.

I just created some Jira issues for them. These were referred to as ship blockers by @switanis as well as the Solution + Baseline tab color change which we checked in a few days ago. I have no clue if @RaiBearG is aware or the release team. Not sure if the serial number issue would also be referred to as a ship blocker.

@john-michaelburke
Copy link
Collaborator Author

Do we have Jira issues for these requests? Does Rai and the release team want to port these to the v4.0.0 branch, if these changes require UAT, then it will potentially delay the launch again.

Stefan has conveyed this to Shahrzad here: https://swift-nav.atlassian.net/browse/CPR-41

@silverjam
Copy link
Contributor

silverjam commented Jul 2, 2022

Do we have Jira issues for these requests? Does Rai and the release team want to port these to the v4.0.0 branch, if these changes require UAT, then it will potentially delay the launch again.

I just created some Jira issues for them. These were referred to as ship blockers by @switanis as well as the Solution + Baseline tab color change which we checked in a few days ago. I have no clue if @RaiBearG is aware or the release team. Not sure if the serial number issue would also be referred to as a ship blocker.

These new issues need to go through the triage process to decide if they are ship blocking or not -- let's make sure @shahrzadshariati and @RaiBearG are aware before we make a decision on whether to back-port.

New tags that are cut on the main branch should be part of the 4.1.x series for the app. If these fixes are going to go to the 4.0.x series, then we'll need to cherry pick them to the appropriate branch (see https://github.com/swift-nav/swift-toolbox/tree/swift-toolbox-v4.0.0-branch).

@john-michaelburke
Copy link
Collaborator Author

john-michaelburke commented Jul 2, 2022

Do we have Jira issues for these requests? Does Rai and the release team want to port these to the v4.0.0 branch, if these changes require UAT, then it will potentially delay the launch again.

I just created some Jira issues for them. These were referred to as ship blockers by @switanis as well as the Solution + Baseline tab color change which we checked in a few days ago. I have no clue if @RaiBearG is aware or the release team. Not sure if the serial number issue would also be referred to as a ship blocker.

These new issues need to go through the triage process to decide if they are ship blocking or not -- let's make sure @shahrzadshariati and @RaiBearG are aware before we make a decision on whether to back-port.

New tags that are cut on the main branch should be part of the 4.1.x series for the app. If these fixes are going to go to the 4.0.x series, then we'll need to cherry pick them to the appropriate branch (see https://github.com/swift-nav/swift-toolbox/tree/swift-toolbox-v4.0.0-branch).

Understood. To summarize the tickets in focus and state of work (the last one I'm not sure if the apps team was aware of):

  • CPP-777 Unify trace colors in Solution/Baseline[CPP-777]. #620 (Ready to be cherry-picked, in my opinion no validation needed)
  • [CPP-785] This pull request. (Not merged to main yet, in my opinion no validation needed)
  • [CPP-786] This pull request. (Not merged to main yet, in my opinion because this is touching Rust and adding a new default state for the Update tab we should perform some minor sanity testing on each OS)
  • [CPP-787] This work is blocked, asking the Qt contractor for more details here: https://snav.slack.com/archives/C02DG3HAHT8/p1656720697361439 (I imagine this work would be a minor change and not require validation)
  • [CPP-784] Make serial_number a string[CPP-784]. libsettings#459 (I'm not sure if this would be deemed a ship blocker but did get brought up by Dennis recently, I'm not sure if the apps team is aware of @RaiBearG , it also looks like our libsettings repo is currently broken which is blocking this from being allowed to merge and I'm not sure how much work that would entail hopefully minor though just merged in this work, ready to be cherry-picked)

@silverjam
Copy link
Contributor

@john-michaelburke Can try to add a few words in the PR summary that mention what was fixed or touched? This will help us when we generate a release changelog to produce something that internal end-users can understand.

@john-michaelburke john-michaelburke merged commit 4b04614 into main Jul 6, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/firmware-file-scan branch July 6, 2022 17:06
john-michaelburke added a commit that referenced this pull request Jul 6, 2022
* Remove firmware file scan on startup.

* Add settings refresh when new sbp/sbp.json file begins recording.
john-michaelburke added a commit that referenced this pull request Jul 6, 2022
* Run chmod on windowpos binary for linux benchmark. (#618)

* Unify trace colors in Solution/Baseline[CPP-777]. (#620)

* Uprev libsettings 0.6.11, serial_number -> string. (#630)

* Few minor fixups.[CPP-785][CPP-786] (#629)

* Remove firmware file scan on startup.

* Add settings refresh when new sbp/sbp.json file begins recording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants