Skip to content

Add recursive directory creation more often[CPP-789] #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2022
Merged

Add recursive directory creation more often[CPP-789] #642

merged 2 commits into from
Jul 8, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jul 8, 2022 •
edited
Loading

  • Adds more exhaustive recursive directory creation before SBP/SBP-JSON/csv logs are created.
  • Catch a panic for the case when the user deletes the folder/file being recorded in the application.

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/create-all-subfolders branch from a6bf605 to 4ec7bf3 Compare July 8, 2022 00:43
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/create-all-subfolders branch from 4ec7bf3 to 0160868 Compare July 8, 2022 00:46
@john-michaelburke john-michaelburke marked this pull request as ready for review July 8, 2022 00:46
@john-michaelburke john-michaelburke requested a review from a team July 8, 2022 00:46
@john-michaelburke john-michaelburke enabled auto-merge (squash) July 8, 2022 01:48
@john-michaelburke john-michaelburke merged commit c229d82 into main Jul 8, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/create-all-subfolders branch July 8, 2022 02:32
john-michaelburke added a commit that referenced this pull request Jul 8, 2022
@john-michaelburke
Add recursive directory creation more often[CPP-789] (#642)
3047f94 
* Add recursive directory creation more often[CPP-789]

* Prevent crash if user deletes folder while recording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam