Skip to content

Windows executable signed, merge sign_app+sign_installer. #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

Windows executable signed, merge sign_app+sign_installer. #651

merged 1 commit into from
Jul 13, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Jul 13, 2022 •
edited
Loading

  • Adds digital signature to windows executable.
  • Merges the sign_application and sign_installer jobs. Having these separated was killing the digital signature on the executable.
    Screen Shot 2022-07-13 at 4 08 38 PM

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/move-mac-to-same-job branch from b7e252d to fbdbf18 Compare July 13, 2022 21:44
john-michaelburke
john-michaelburke commented Jul 13, 2022
View reviewed changes
.github/workflows/main.yml
run: |
"${{ env.CODE_SIGNER_PATH_WIN }}" sign ^
/debug /v ^
/debug /v /td SHA256 ^
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange behavior in uprevving the codesign tool on Windows, shifting the command line arg to a different position seemed to make it work 🤷

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/move-mac-to-same-job branch from fbdbf18 to 6101ff6 Compare July 13, 2022 22:36
@john-michaelburke john-michaelburke marked this pull request as ready for review July 13, 2022 23:09
@john-michaelburke john-michaelburke requested a review from a team July 13, 2022 23:09
@john-michaelburke john-michaelburke merged commit 4ea8152 into main Jul 13, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/move-mac-to-same-job branch July 13, 2022 23:17
john-michaelburke added a commit that referenced this pull request Jul 13, 2022
@john-michaelburke
Windows executable signed, merge sign_app+sign_installer. (#651)
c7fe675
john-michaelburke added a commit that referenced this pull request Jul 14, 2022
@john-michaelburke
Windows executable signed, merge sign_app+sign_installer. (#651) (#652)
b1135ad
@silverjam silverjam mentioned this pull request Sep 29, 2022
Merged
This was referenced Jul 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam