Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2022

Bumps sysinfo from 0.25.2 to 0.26.0.

Changelog

Sourced from sysinfo's changelog.

0.26.0

  • Switch memory unit from kilobytes to bytes.
  • Windows: Fix Windows version display on Windows 11.

0.25.3

  • Add macOS M1 CI checks.
  • macOS M1: Add temperature support.
  • macOS: Fix leak in disk retrieval.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @silverjam.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Aug 29, 2022
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot rebase
@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/cargo/sysinfo-0.26.0 branch from 720602a to a594211 Compare August 30, 2022 16:14
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@silverjam
Copy link
Contributor

@dependabot rebase
@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/cargo/sysinfo-0.26.0 branch from a594211 to 4d2f23b Compare August 30, 2022 18:06
@silverjam
Copy link
Contributor

@john-michaelburke I think there's a breaking change in this dependency update that causing the memory benchmarks to fail:

Switch memory unit from kilobytes to bytes.

Are we using the sysinfo crate to grab memory usage anywhere directly?

@john-michaelburke
Copy link
Collaborator

@john-michaelburke I think there's a breaking change in this dependency update that causing the memory benchmarks to fail:

Switch memory unit from kilobytes to bytes.

Are we using the sysinfo crate to grab memory usage anywhere directly?

Yeah you are right we were using this with the intention of kilobytes. Also this failed test indicates there was a pretty large jump in memory usage. Our threshold for max was roughly 22Mb and this is showing a mean of ~30Mb, I guess this is still pretty minor but interesting.

dependabot bot and others added 2 commits August 30, 2022 12:48
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.25.2 to 0.26.0.
- [Release notes](https://github.com/GuillaumeGomez/sysinfo/releases)
- [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/GuillaumeGomez/sysinfo/commits)

---
updated-dependencies:
- dependency-name: sysinfo
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@john-michaelburke john-michaelburke force-pushed the dependabot/cargo/sysinfo-0.26.0 branch from 2332b1f to 3739640 Compare August 30, 2022 19:48
@silverjam silverjam enabled auto-merge (squash) August 30, 2022 20:00
@john-michaelburke john-michaelburke force-pushed the dependabot/cargo/sysinfo-0.26.0 branch from 65e1019 to b5c0342 Compare August 31, 2022 01:51
@silverjam silverjam merged commit 39e494a into main Aug 31, 2022
@silverjam silverjam deleted the dependabot/cargo/sysinfo-0.26.0 branch August 31, 2022 02:58
adrian-kong added a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants