[CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). #77

john-michaelburke · 2021-06-23T20:57:39Z

Done

Baseline Plot ~~(minus zoom / center features and reset filters button)~~
Baseline Table

Todo

~~Zoom / Center Features: https://swift-nav.atlassian.net/browse/CPP-245~~

Won't get to

The reset filters button requires the new connection object to be propogated down to the tab. This will probably require a slight refactor for all tabs so left out of this PR. Ticket here: https://swift-nav.atlassian.net/browse/CPP-246
Also wouldn't hurt to add more unittests for some of the more involved functions here: https://swift-nav.atlassian.net/browse/CPP-248

EDIT: Zoom/Center Solution functionality:

double click plot to reset to original zoom all
mouse wheel scroll in / out by increments of 1.1/0.9
click and drag in certain direction (should kill zoom all or center solution)
only center solution or zoom all should be active at once but can both be deselected during free zoom.

…aelburke/baseline

jayvdb · 2021-06-24T06:37:23Z

console_backend/src/constants.rs

+pub(crate) const E_FLOAT: &str = "e_Float RTK";
+pub(crate) const E_FIXED: &str = "e_Fixed RTK";
+pub(crate) const E_DGNSS: &str = "e_DGPS";
+pub(crate) const N: &str = "N";


more meaningful names needed for N/E/D

jayvdb · 2021-06-24T06:41:28Z

src/main/python/baseline_plot.py

+}
+
+
+class BaselinePlotPoints(QObject):  # pylint: disable=too-many-instance-attributes,too-many-public-methods


too-many-instance-attributes,too-many-public-methods ? is this copy-paste error? if not, maybe some pylint config can bump up the minimum to a more reasonable default.

Removed. You were right this was a copy paste error. Shame 👀

jayvdb · 2021-06-24T06:42:24Z

resources/BaselineTabComponents/BaselinePlot.qml

+                    interval: Utils.hzToMilliseconds(Globals.currentRefreshRate)
+                    running: true
+                    repeat: true
+                    onTriggered: {


this looks large enough to warrant being put into a standalone .js file

I broke out a decent amount into the BaselinePlotLoop.js file and sadly this sent me down quite the rabbit hole. A few findings from trying to move most of this to a separate js file:

I was able to figure out importing QtCharts in order to make chartview series which is pretty cool.

For the life of me I could not get the Constants/Globals to import which I think is a flaw in our implementation of the singleton. I filed a support request with qt then we can drop in replace it to this file: https://account.qt.io/support/request/INC-1654147

There are a lot of global objects used here that must be passed in as arguments or we would need to use javascript functions to grab pointers to them which works but can be cumbersome as the number of objects grow. One workaround to this would be placing the javascript files directly in the QML such as I did originally in this script but it definitely results in the qml file being fairly cluttered.

…aelburke/baseline

notoriaga · 2021-06-28T22:34:16Z

console_backend/src/baseline_tab.rs

+    /// - `exclude_mode`: The mode as a string not to update. Otherwise, None.
+    fn _append_empty_sln_data(&mut self, exclude_mode: Option<String>) {
+        for each_mode in self.mode_strings.iter() {
+            if exclude_mode.is_some() {


should this be something along the lines of

if exclude_mode == Some(each_mode) { continue; }

looks like currently if exclude_mode is Some(_) all of the modes will be skipped

Fixed. Wow good catch. This was an artifact of me shamelessly copying over the work from the solution tab 😬. This bug was in the solution tab since I implemented it. This was one of the functions under the umbrella of "need more unitests" bugs I have filed.
https://swift-nav.atlassian.net/browse/CPP-248
https://swift-nav.atlassian.net/browse/CPP-107

console_backend/src/baseline_tab.rs

notoriaga · 2021-06-28T22:43:01Z

console_backend/src/baseline_tab.rs

+pub(crate) struct BaselineTabButtons {
+    clear: bool,
+    pause: bool,
+    _reset: bool,


nit: probably don't need the _

or is this because the reset isn't implemented?

Yeah this is currently not used. Will need to wait for the "trickle ticket" 😂 to get implemented first.

john-michaelburke added 5 commits June 18, 2021 14:17

Baseline.

0faf962

Merge branch 'main' of github.com:swift-nav/console_pp into john-mich…

2f723bb

…aelburke/baseline

Begin working on table qml.

1c688b2

Baseline Plot.

ff99a86

Merge branch 'main' of github.com:swift-nav/console_pp into john-mich…

30a0604

…aelburke/baseline

john-michaelburke force-pushed the john-michaelburke/baseline branch from 93e81ee to c26fe7d Compare June 23, 2021 21:06

john-michaelburke requested a review from a team June 23, 2021 21:32

john-michaelburke marked this pull request as ready for review June 23, 2021 21:32

john-michaelburke changed the title [CPP-218][CPP-219][CPP-42] Baseline Table + Plot (front and back). *WIP* [CPP-218][CPP-219][CPP-42][CPP-43] Baseline Table + Plot (front and back). *WIP* Jun 23, 2021

john-michaelburke changed the title [CPP-218][CPP-219][CPP-42][CPP-43] Baseline Table + Plot (front and back). *WIP* [CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). *WIP* Jun 23, 2021

jayvdb reviewed Jun 24, 2021

View reviewed changes

john-michaelburke added 2 commits June 24, 2021 14:17

Continuing baseline plot.

d065377

Added zoom all and center on solution feature to Baseline plot.

6a42c6d

john-michaelburke force-pushed the john-michaelburke/baseline branch from c26fe7d to 6a42c6d Compare June 25, 2021 03:31

john-michaelburke changed the title [CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). *WIP* [CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). Jun 25, 2021

Respond to review requests.

0f99ceb

john-michaelburke force-pushed the john-michaelburke/baseline branch from 7b44573 to 0f99ceb Compare June 25, 2021 20:57

john-michaelburke requested review from a team and jayvdb June 25, 2021 20:59

john-michaelburke added 2 commits June 28, 2021 10:42

Merge branch 'main' of github.com:swift-nav/console_pp into john-mich…

8f3af8c

…aelburke/baseline

Merge branch 'main' of github.com:swift-nav/console_pp into john-mich…

f2f7a05

…aelburke/baseline

notoriaga reviewed Jun 28, 2021

View reviewed changes

console_backend/src/baseline_tab.rs Show resolved Hide resolved

notoriaga reviewed Jun 28, 2021

View reviewed changes

Clean up clear_sln and fix bug in append_empty_data function.

679038a

john-michaelburke requested a review from notoriaga June 28, 2021 23:54

jayvdb approved these changes Jun 29, 2021

View reviewed changes

notoriaga approved these changes Jun 29, 2021

View reviewed changes

john-michaelburke merged commit d5967e1 into main Jun 29, 2021

john-michaelburke deleted the john-michaelburke/baseline branch June 29, 2021 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). #77

[CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). #77

Uh oh!

john-michaelburke commented Jun 23, 2021 •

edited

Loading

Uh oh!

jayvdb Jun 24, 2021

Uh oh!

john-michaelburke Jun 25, 2021

Uh oh!

jayvdb Jun 24, 2021

Uh oh!

john-michaelburke Jun 25, 2021

Uh oh!

jayvdb Jun 24, 2021

Uh oh!

john-michaelburke Jun 25, 2021 •

edited

Loading

Uh oh!

notoriaga Jun 28, 2021 •

edited

Loading

Uh oh!

john-michaelburke Jun 28, 2021

Uh oh!

Uh oh!

notoriaga Jun 28, 2021

Uh oh!

notoriaga Jun 28, 2021

Uh oh!

john-michaelburke Jun 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		}


		class BaselinePlotPoints(QObject): # pylint: disable=too-many-instance-attributes,too-many-public-methods

[CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). #77

[CPP-218][CPP-42][CPP-43] Baseline Table + Plot (front and back). #77

Uh oh!

Conversation

john-michaelburke commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Done

Todo

Won't get to

EDIT: Zoom/Center Solution functionality:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

john-michaelburke Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

notoriaga Jun 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

john-michaelburke commented Jun 23, 2021 •

edited

Loading

john-michaelburke Jun 25, 2021 •

edited

Loading

notoriaga Jun 28, 2021 •

edited

Loading